From e07f769288b60bfc226d37ca7154fcf61bbba7cf Mon Sep 17 00:00:00 2001
From: Toba Ojo <toba.ojo@mav-systems.com>
Date: Wed, 26 Nov 2025 13:00:41 +0000
Subject: [PATCH] - refactor: replace Output component with OutputForms and
 update related hooks and types

---
 .../dashboard/components/SystemHealth.tsx     |  2 +-
 .../dashboard/components/SystemOverview.tsx   |  1 -
 .../output/components/BearerTypeFields.tsx    |  4 +-
 .../output/components/ChannelCard.tsx         |  6 +-
 .../output/components/ChannelFields.tsx       |  9 +--
 src/features/output/components/Output.tsx     | 50 ------------
 .../output/components/OutputForms.tsx         | 81 +++++++++++++++++++
 src/features/output/hooks/useBearer.ts        | 65 +++++++++++++++
 .../output/hooks/useDispatcherConfig.ts       | 47 +++++++++++
 src/features/output/hooks/useGetOutputs.ts    | 20 -----
 .../output/hooks/useOptionalConstants.tsx     |  0
 src/features/output/hooks/usePostOutputs.ts   | 21 -----
 src/routes/output.tsx                         |  4 +-
 src/types/types.ts                            | 26 ++++++
 14 files changed, 232 insertions(+), 104 deletions(-)
 delete mode 100644 src/features/output/components/Output.tsx
 create mode 100644 src/features/output/components/OutputForms.tsx
 create mode 100644 src/features/output/hooks/useBearer.ts
 create mode 100644 src/features/output/hooks/useDispatcherConfig.ts
 delete mode 100644 src/features/output/hooks/useGetOutputs.ts
 create mode 100644 src/features/output/hooks/useOptionalConstants.tsx
 delete mode 100644 src/features/output/hooks/usePostOutputs.ts

diff --git a/src/features/dashboard/components/SystemHealth.tsx b/src/features/dashboard/components/SystemHealth.tsx
index de4f3b4..4a21206 100644
--- a/src/features/dashboard/components/SystemHealth.tsx
+++ b/src/features/dashboard/components/SystemHealth.tsx
@@ -19,7 +19,7 @@ const SystemHealth = ({ startTime, uptime, statuses, isLoading, isError, dateUpd
   if (isLoading) {
     return <span className="text-slate-500">Loading system health…</span>;
   }
-
+  console.log(statuses);
   return (
     <div className="h-100 md:h-75 overflow-y-auto flex flex-col gap-4">
       <div className="p-2 border-b border-gray-600 grid grid-cols-2 justify-between">
diff --git a/src/features/dashboard/components/SystemOverview.tsx b/src/features/dashboard/components/SystemOverview.tsx
index c7aba54..b440e22 100644
--- a/src/features/dashboard/components/SystemOverview.tsx
+++ b/src/features/dashboard/components/SystemOverview.tsx
@@ -14,7 +14,6 @@ const SystemOverview = () => {
   const isError = query?.isError;
   const dateUpdatedAt = query?.dataUpdatedAt;
 
-  console.log(query?.dataUpdatedAt);
   return (
     <Card className="p-4">
       <CardHeader title="System Health" refetch={query?.refetch} icon={faArrowsRotate} />
diff --git a/src/features/output/components/BearerTypeFields.tsx b/src/features/output/components/BearerTypeFields.tsx
index dccbd26..6257bc3 100644
--- a/src/features/output/components/BearerTypeFields.tsx
+++ b/src/features/output/components/BearerTypeFields.tsx
@@ -1,6 +1,8 @@
-import { Field } from "formik";
+import { Field, useFormikContext } from "formik";
+import type { FormTypes } from "../../../types/types";
 
 const BearerTypeFields = () => {
+  useFormikContext<FormTypes>();
   return (
     <div className="flex flex-row justify-between">
       <label htmlFor="format" className="text-xl">
diff --git a/src/features/output/components/ChannelCard.tsx b/src/features/output/components/ChannelCard.tsx
index 3ba087e..bab00ed 100644
--- a/src/features/output/components/ChannelCard.tsx
+++ b/src/features/output/components/ChannelCard.tsx
@@ -3,12 +3,12 @@ import Card from "../../../ui/Card";
 import CardHeader from "../../../ui/CardHeader";
 import ChannelFields from "./ChannelFields";
 import type { FormTypes } from "../../../types/types";
-import { useGetOutputs } from "../hooks/useGetOutputs";
+import { useGetBearerConfig } from "../hooks/useBearer";
 
 const ChannelCard = () => {
   const { values, errors, touched, setFieldValue } = useFormikContext<FormTypes>();
-  const { query } = useGetOutputs(values?.format?.toLowerCase() || "json");
-  const outputData = query?.data;
+  const { bearerQuery } = useGetBearerConfig(values?.format?.toLowerCase() || "json");
+  const outputData = bearerQuery?.data;
   return (
     <Card className="p-4 h-150 md:h-full">
       <CardHeader title={`Channel (${values?.format})`} />
diff --git a/src/features/output/components/ChannelFields.tsx b/src/features/output/components/ChannelFields.tsx
index 7422211..6162946 100644
--- a/src/features/output/components/ChannelFields.tsx
+++ b/src/features/output/components/ChannelFields.tsx
@@ -1,6 +1,5 @@
 import { Field } from "formik";
-import type { FormTypes, InitialValuesFormErrors } from "../../../types/types";
-import type { UseQueryResult } from "@tanstack/react-query";
+import type { FormTypes, InitialValuesFormErrors, OutputDataResponse } from "../../../types/types";
 import { useEffect, useMemo } from "react";
 
 type ChannelFieldsProps = {
@@ -10,15 +9,15 @@ type ChannelFieldsProps = {
     connectTimeoutSeconds?: boolean | undefined;
     readTimeoutSeconds?: boolean | undefined;
   };
-  outputData?: UseQueryResult<FormTypes, Error>;
+  outputData?: OutputDataResponse;
   onSetFieldValue: (field: string, value: string, shouldValidate?: boolean | undefined) => void;
 };
 
 const ChannelFields = ({ errors, touched, values, outputData, onSetFieldValue }: ChannelFieldsProps) => {
   const channelFieldsObject = useMemo(() => {
     return {
-      connectTimeoutSeconds: outputData?.propConnectTimeoutSeconds?.value || 5,
-      readTimeoutSeconds: outputData?.propReadTimeoutSeconds?.value || 15,
+      connectTimeoutSeconds: outputData?.propConnectTimeoutSeconds?.value || "5",
+      readTimeoutSeconds: outputData?.propReadTimeoutSeconds?.value || "15",
       backOfficeURL: outputData?.propBackofficeURL?.value || "",
       username: outputData?.propUsername?.value || "",
       password: outputData?.propPassword?.value || "",
diff --git a/src/features/output/components/Output.tsx b/src/features/output/components/Output.tsx
deleted file mode 100644
index 4e43205..0000000
--- a/src/features/output/components/Output.tsx
+++ /dev/null
@@ -1,50 +0,0 @@
-import { Formik, Form } from "formik";
-import BearerTypeCard from "./BearerTypeCard";
-import ChannelCard from "./ChannelCard";
-import type { FormTypes } from "../../../types/types";
-import { usePostOutputs } from "../hooks/usePostOutputs";
-
-const Output = () => {
-  const { mutation } = usePostOutputs();
-  const handleSubmit = (values: FormTypes) => {
-    const channelFields = {
-      backOfficeURL: values.backOfficeURL,
-      username: values.username,
-      password: values.password,
-    };
-  };
-
-  const inititalValues: FormTypes = {
-    format: "JSON",
-    enabled: true,
-    backOfficeURL: "",
-    username: "",
-    password: "",
-    connectTimeoutSeconds: Number(5),
-    readTimeoutSeconds: Number(15),
-    overviewQuality: "HIGH",
-    cropSizeFactor: "3/4",
-
-    // Bof2 -optional constants
-    FFID: "",
-    SCID: "",
-    timestampSource: "UTC",
-    GPSFormat: "Minutes",
-
-    //BOF2 - optional Lane IDs
-    laneId: "",
-    LID1: "",
-    LID2: "",
-  };
-
-  return (
-    <Formik initialValues={inititalValues} onSubmit={handleSubmit} enableReinitialize>
-      <Form className="grid grid-cols-1 md:grid-cols-2">
-        <BearerTypeCard />
-        <ChannelCard />
-      </Form>
-    </Formik>
-  );
-};
-
-export default Output;
diff --git a/src/features/output/components/OutputForms.tsx b/src/features/output/components/OutputForms.tsx
new file mode 100644
index 0000000..8f8fe88
--- /dev/null
+++ b/src/features/output/components/OutputForms.tsx
@@ -0,0 +1,81 @@
+import { Formik, Form } from "formik";
+import BearerTypeCard from "./BearerTypeCard";
+import ChannelCard from "./ChannelCard";
+import type { BearerTypeFields, FormTypes, OptionalBOF2Constants } from "../../../types/types";
+import { usePostBearerConfig } from "../hooks/useBearer";
+import { useDispatcherConfig } from "../hooks/useDispatcherConfig";
+
+const OutputForms = () => {
+  const { bearerMutation } = usePostBearerConfig();
+  const { dispatcherQuery, dispatcherMutation } = useDispatcherConfig();
+
+  const format = dispatcherQuery?.data?.propFormat?.value;
+
+  const inititalValues: FormTypes = {
+    format: format ?? "JSON",
+    enabled: true,
+    backOfficeURL: "",
+    username: "",
+    password: "",
+    connectTimeoutSeconds: Number(5),
+    readTimeoutSeconds: Number(15),
+    overviewQuality: "HIGH",
+    cropSizeFactor: "3/4",
+
+    // Bof2 -optional constants
+    FFID: "",
+    SCID: "",
+    timestampSource: "UTC",
+    GPSFormat: "Minutes",
+
+    //BOF2 - optional Lane IDs
+    laneId: "",
+    LID1: "",
+    LID2: "",
+  };
+
+  const handleSubmit = async (values: FormTypes) => {
+    const bearerTypeFields = {
+      format: values.format,
+      enabled: values.enabled,
+    };
+
+    const bearerFields: BearerTypeFields = {
+      format: values.format,
+      enabled: values.enabled,
+      backOfficeURL: values.backOfficeURL,
+      username: values.username,
+      password: values.password,
+      connectTimeoutSeconds: values.connectTimeoutSeconds,
+      readTimeoutSeconds: values.readTimeoutSeconds,
+      overviewQuality: values.overviewQuality,
+      cropSizeFactor: values.cropSizeFactor,
+    };
+
+    const result = await dispatcherMutation.mutateAsync(bearerTypeFields);
+
+    if (result?.id) {
+      await bearerMutation.mutateAsync(bearerFields);
+      if (values.format === "BOF2") {
+        const optionalBOF2Fields: OptionalBOF2Constants = {
+          FFID: values.FFID,
+          SCID: values.SCID,
+          timestampSource: values.timestampSource,
+          GPSFormat: values.GPSFormat,
+        };
+        console.log("Submit BOF2 optional fields:", optionalBOF2Fields);
+      }
+    }
+  };
+
+  return (
+    <Formik initialValues={inititalValues} onSubmit={handleSubmit} enableReinitialize>
+      <Form className="grid grid-cols-1 md:grid-cols-2">
+        <BearerTypeCard />
+        <ChannelCard />
+      </Form>
+    </Formik>
+  );
+};
+
+export default OutputForms;
diff --git a/src/features/output/hooks/useBearer.ts b/src/features/output/hooks/useBearer.ts
new file mode 100644
index 0000000..33c9884
--- /dev/null
+++ b/src/features/output/hooks/useBearer.ts
@@ -0,0 +1,65 @@
+import { useMutation, useQuery } from "@tanstack/react-query";
+import type { BearerTypeFields } from "../../../types/types";
+
+const fetchBearerConfig = async (bearerConfig: string) => {
+  const response = await fetch(`http://100.115.148.59/api/fetch-config?id=Dispatcher0-${bearerConfig}`, {
+    method: "GET",
+  });
+  if (!response.ok) {
+    throw new Error("Network response was not ok");
+  }
+  return response.json();
+};
+
+const postBearerConfig = async (config: BearerTypeFields) => {
+  const channelConfigPayload = {
+    id: `Dispatcher0-${config.format.toLowerCase()}`,
+    fields: [
+      {
+        property: "propBackofficeURL",
+        value: config.backOfficeURL,
+      },
+      {
+        property: "propConnectTimeoutSeconds",
+        value: config.connectTimeoutSeconds,
+      },
+      {
+        property: "propPassword",
+        value: config.password,
+      },
+      {
+        property: "propReadTimeoutSeconds",
+        value: config.readTimeoutSeconds,
+      },
+      {
+        property: "propUsername",
+        value: config.username,
+      },
+    ],
+  };
+  const response = await fetch("http://192.168.202.121/api/update-config", {
+    method: "POST",
+    body: JSON.stringify(channelConfigPayload),
+  });
+  if (!response.ok) {
+    throw new Error("Network response was not ok");
+  }
+  return response.json();
+};
+
+export const usePostBearerConfig = () => {
+  const bearerMutation = useMutation({
+    mutationFn: (query: BearerTypeFields) => postBearerConfig(query),
+    mutationKey: ["outputs"],
+  });
+  return { bearerMutation };
+};
+
+export const useGetBearerConfig = (bearerConfig: string) => {
+  const bearerQuery = useQuery({
+    queryKey: ["outputs", bearerConfig],
+    queryFn: () => fetchBearerConfig(bearerConfig),
+  });
+
+  return { bearerQuery };
+};
diff --git a/src/features/output/hooks/useDispatcherConfig.ts b/src/features/output/hooks/useDispatcherConfig.ts
new file mode 100644
index 0000000..aa9021b
--- /dev/null
+++ b/src/features/output/hooks/useDispatcherConfig.ts
@@ -0,0 +1,47 @@
+import { useQuery, useMutation } from "@tanstack/react-query";
+import type { DispatcherConfig } from "../../../types/types";
+
+const getDispatcherConfig = async () => {
+  const response = await fetch(`http://192.168.202.121/api/fetch-config?id=Dispatcher0`);
+  if (!response.ok) {
+    throw new Error("Network response was not ok");
+  }
+  return response.json();
+};
+
+const postDispatcherConfig = async (config: DispatcherConfig) => {
+  const updateConfigPayload = {
+    id: "Dispatcher0",
+    fields: [
+      {
+        property: "propEnabled",
+        value: config.enabled,
+      },
+      {
+        property: "propFormat",
+        value: config.format,
+      },
+    ],
+  };
+  const response = await fetch(`http://192.168.202.121/api/update-config`, {
+    method: "POST",
+    body: JSON.stringify(updateConfigPayload),
+  });
+  if (!response.ok) {
+    throw new Error("Network response was not ok");
+  }
+  return response.json();
+};
+
+export const useDispatcherConfig = () => {
+  const dispatcherQuery = useQuery({
+    queryKey: ["dispatcherConfig"],
+    queryFn: () => getDispatcherConfig(),
+  });
+
+  const dispatcherMutation = useMutation({
+    mutationKey: ["postDispatcherConfig"],
+    mutationFn: (config: DispatcherConfig) => postDispatcherConfig(config),
+  });
+  return { dispatcherQuery, dispatcherMutation };
+};
diff --git a/src/features/output/hooks/useGetOutputs.ts b/src/features/output/hooks/useGetOutputs.ts
deleted file mode 100644
index e7b52b9..0000000
--- a/src/features/output/hooks/useGetOutputs.ts
+++ /dev/null
@@ -1,20 +0,0 @@
-import { useQuery } from "@tanstack/react-query";
-
-const fetchOutputs = async (format: string) => {
-  const response = await fetch(`http://100.115.148.59/api/fetch-config?id=Dispatcher0-${format}`, {
-    method: "GET",
-  });
-  if (!response.ok) {
-    throw new Error("Network response was not ok");
-  }
-  return response.json();
-};
-
-export const useGetOutputs = (format: string) => {
-  const query = useQuery({
-    queryKey: ["outputs", format],
-    queryFn: () => fetchOutputs(format),
-  });
-
-  return { query };
-};
diff --git a/src/features/output/hooks/useOptionalConstants.tsx b/src/features/output/hooks/useOptionalConstants.tsx
new file mode 100644
index 0000000..e69de29
diff --git a/src/features/output/hooks/usePostOutputs.ts b/src/features/output/hooks/usePostOutputs.ts
deleted file mode 100644
index d498bc1..0000000
--- a/src/features/output/hooks/usePostOutputs.ts
+++ /dev/null
@@ -1,21 +0,0 @@
-import { useMutation } from "@tanstack/react-query";
-import type { BearerTypeFields } from "../../../types/types";
-
-const postQuery = async (query: BearerTypeFields) => {
-  const response = await fetch("/api/outputs", {
-    method: "POST",
-    body: JSON.stringify({ query }),
-  });
-  if (!response.ok) {
-    throw new Error("Network response was not ok");
-  }
-  return response.json();
-};
-
-export const usePostOutputs = () => {
-  const mutation = useMutation({
-    mutationFn: (query: BearerTypeFields) => postQuery(query),
-    mutationKey: ["outputs"],
-  });
-  return { mutation };
-};
diff --git a/src/routes/output.tsx b/src/routes/output.tsx
index 10b16e8..f1be44e 100644
--- a/src/routes/output.tsx
+++ b/src/routes/output.tsx
@@ -1,5 +1,5 @@
 import { createFileRoute } from "@tanstack/react-router";
-import Output from "../features/output/components/Output";
+import OutputForms from "../features/output/components/OutputForms";
 
 export const Route = createFileRoute("/output")({
   component: RouteComponent,
@@ -8,7 +8,7 @@ export const Route = createFileRoute("/output")({
 function RouteComponent() {
   return (
     <div>
-      <Output />
+      <OutputForms />
     </div>
   );
 }
diff --git a/src/types/types.ts b/src/types/types.ts
index 94366e5..4477f7a 100644
--- a/src/types/types.ts
+++ b/src/types/types.ts
@@ -57,7 +57,33 @@ export type InitialValuesFormErrors = {
 };
 
 export type FormTypes = BearerTypeFields & OptionalConstants & OptionalLaneIDs;
+type FieldProperty = {
+  datatype: string;
+  value: string;
+};
+export type OutputDataResponse = {
+  id: string;
+  configHash: string;
+} & Record<string, FieldProperty>;
 
 export type PaintedCell = {
   colour: string;
 };
+
+export type DispatcherConfig = {
+  format: string;
+  enabled: boolean;
+};
+
+export type OptionalBOF2Constants = {
+  FFID?: string;
+  SCID?: string;
+  timestampSource?: string;
+  GPSFormat?: string;
+};
+export type OptionalBOF2LaneIDs = {
+  laneId?: string;
+  LID1?: string;
+  LID2?: string;
+  LID3?: string;
+};